add flag "Corporate rights abroad"

excieve / dragnet

Catching the big fish

MIT License

2 stars 1 forks source link

add flag "Corporate rights abroad" #24

Closed pro100olga closed 4 years ago

pro100olga commented 6 years ago

Считались ли показатели corprights.companies_qty.d.abr, corprights.companies_qty.f.abr, corprights.companies_qty.u.abr? Если да, то условие: показатель corprights.companies_qty.d.abr +corprights.companies_qty.f.abr +corprights.companies_qty.u.abr > 0 Если нет, то условие: в json-е есть записи, для которых data$step_8$country > 1 Записать в переменную corprights.abroad.flag (значения True / False)

pro100olga commented 6 years ago

There are some cases when 'step_8' is a nested list - in this case flag is equal to True, while it should be false, as users actually do not have corporate rights at all.

Examples: nacp_825dcde8-da9e-4628-8f7d-2c9e33e84045 nacp_56f30d56-25a9-402b-b9fb-2123b3faaf50 nacp_58db99ea-e28d-4001-b4a5-76ea64d998fe nacp_584d67ef-9ed3-423a-8ff1-a09dd2412b7c nacp_082ffb62-44b2-4115-93ba-1a5e50ec14f1 nacp_5a87776d-28fa-4484-ae4b-ea24ae680ae4 nacp_67617249-fd47-4388-b998-c75d801ec92a nacp_5629ba83-d4cd-41c9-952a-b6446bd9d796

pro100olga commented 4 years ago

Checked on part of data sent on 01/03/20 (67K rows) 18 True values - all ok Still need to check the full dataset, including those examples with nested lists, mentioned in comment above (none of these declarations were among 67K)

pro100olga commented 4 years ago

Checked on annual 2017 declarations (~800K) using this code: https://github.com/pro100olga/declarations/tree/master/bi/red_flags/flags_03_2020

All ok, Closed.