excieve / dragnet

Catching the big fish
MIT License
2 stars 1 forks source link

New batch of flags and fields #32

Closed excieve closed 6 years ago

excieve commented 6 years ago

estate_has_hidden_cost: resolves #22 family_member_did_not_provide_information_flag: resolves #23 corprights_abroad_flag: resolves #24 income_prize_fact and incomes.prize: resolves #25 bank_accounts_abroad_flag: resolves #26 assets_lend_3rd_parties_flag: resolves #27 cash_flag_500k: resolves #28 income_presents_to_total_flag_50: resolves #29

In addition to the above, the version of CouchDB is updated to 2.1.1 in the Dockerfile.

excieve commented 6 years ago

Note that family_member_did_not_provide_information_flag currently differs from specification in the ticket because there's no "Член сім'ї не надав інформацію" value in any of the JSONs I have. I've found it in some HTML files though, but for now decided to avoid changing the parsing code so that full re-import would not be required and we wouldn't depend on something that looks like a changeable template message.

The way it works in this PR is by checking whether any object is related to a family member and has hidden information. If at least one has the flag is raised. Please let me know if that's an overkill and something else would work better.