search

excieve / dragnet

Catching the big fish
MIT License
2 stars 1 forks source link

add flag "has_foreign_real_estate" #41

Closed pro100olga closed 4 years ago

pro100olga commented 4 years ago

Has real estate object (житлова нерухомість) abroad (on any form of owning)

Final description of the flag (written before closing issue): Check all estate objects. Raise the flag if there is an object for which:

pro100olga commented 4 years ago

Checked on partial data (67K rows) 10 files checked - all ok

Need to check on full dataset

pro100olga commented 4 years ago

Checked on annual 2017 declarations (~800K) using this code: https://github.com/pro100olga/declarations/tree/master/bi/red_flags/flags_03_2020

Detected 193 documents where flag is False while should e True, e.g.: nacp_4a0bd17e-56ed-40f1-a16f-4a158da17319 nacp_49d7133e-4733-4dbe-8f3e-993294ed4b45 nacp_497640d3-9a40-484a-8a3c-3a00e9d57cc4 nacp_44b164c6-edb0-4fe0-b7b8-e062c79144ea nacp_4538c079-501d-46b6-9d84-40d39c3288a0

Is ownership somehow considered here? Cause these declarations above all have estate objects abroad on leasing \ free of charge usage, etc

@dchaplinsky please comment

dchaplinsky commented 4 years ago

У розділі декларації "Об’єкти нерухомості" зазначено об’єкт нерухомості, що належить суб’єкту декларування або члену сім’ї на праві власності, спільної власності, або власником об’єкта є третя особа, якщо при цьому країною місцезнаходження такого об’єкта є інша країна, ніж Україна

pro100olga commented 4 years ago

Checked on partial data of annual decl-s for 2017 (~18K).

False, but should be True: nacp_e53295ab-148f-4ce8-a4d9-24299cfc04d2

dchaplinsky commented 4 years ago

Should be fixed now (she had other real estate type)

pro100olga commented 4 years ago

Checked on ~500K documents from annual 2017 decl ~100 mismatches

nacp_d88d3f32-43de-4ac8-be9e-7f8051e68cbf nacp_ea669f79-1383-4ba7-a7c7-ac60ea8cdd21

Is it filtered for type of estate? E.g., here nacp_d734faa3-39d2-4b46-b29b-18d481feeab0 there is garage and office abroad I guess it includes 'Житловий будинок', 'Квартира', 'Кімната', 'Садовий (дачний) будинок' but please confirm

True, but should be False nacp_4a0bd17e-56ed-40f1-a16f-4a158da17319 nacp_e57e2217-c5cf-433b-b019-2f7a212b8b76 nacp_a12c37f8-4719-45be-9109-905ff8cc923d

dchaplinsky commented 4 years ago

wrt "True, but should be False"

Previously you wrote:

Is ownership somehow considered here? Cause these declarations above all have estate objects abroad on leasing \ free of charge usage, etc So I've removed a clause on ownership rights and now considering any kind of ownership rights. Should I move it back? Should I limit them to some list? Please, advice

On Wed, Apr 1, 2020 at 9:49 PM Olga Makarova notifications@github.com wrote:

Checked on ~500K documents from annual 2017 decl ~100 mismatches

nacp_d88d3f32-43de-4ac8-be9e-7f8051e68cbf nacp_ea669f79-1383-4ba7-a7c7-ac60ea8cdd21

Is it filtered for type of estate? E.g., here nacp_d734faa3-39d2-4b46-b29b-18d481feeab0 there is garage and office abroad

True, but should be False nacp_4a0bd17e-56ed-40f1-a16f-4a158da17319 nacp_e57e2217-c5cf-433b-b019-2f7a212b8b76 nacp_a12c37f8-4719-45be-9109-905ff8cc923d

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/excieve/dragnet/issues/41#issuecomment-607428003, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABAA4QP6WETIX5L4CY53F3RKOECVANCNFSM4K7VSXWA .

pro100olga commented 4 years ago

My suggestions:

pro100olga commented 4 years ago

Checked on 500K documents (annual declarations from 2017) using this code

All ok. Closed.

Final description of the flag: Check all estate objects. Raise the flag if there is an object for which: