search

excitement-engineer / graphql-iso-date

A set of RFC 3339 compliant date/time GraphQL scalar types.
MIT License
523 stars 50 forks source link

Fix typo / information mismatch in README #113

Closed NWRichmond closed 4 years ago

NWRichmond commented 4 years ago

Since the input for birthdate is new Date(1991, 11, 24), the logs should read 1991-11-24 and not 1991-12-24.

codecov[bot] commented 4 years ago

Codecov Report

Merging #113 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #113   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         146    146           
  Branches       40     40           
=====================================
  Hits          146    146

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8979ce8...bf0475d. Read the comment docs.

excitement-engineer commented 4 years ago

Thanks for the PR!

The month in a javascript date starts at 0 for January, 1 for febuary and so on. So the original log is correct.

NWRichmond commented 4 years ago

Wow, I should really know better than to have missed that!

Thank you for your gracious answer, @excitement-engineer.