search

excitement-engineer / graphql-iso-date

A set of RFC 3339 compliant date/time GraphQL scalar types.
MIT License
523 stars 50 forks source link

GraphQL 15 support #138

Open Pompedup opened 3 years ago

Pompedup commented 3 years ago

I just begin a tutorial with graphql that use your lib, they use graphql@15.5.0 so I had to do npm i -force to install your lib since you don't allow GraphQL 15, is there a reason or will that be possible soon ?

Urigo commented 3 years ago

Could you link the tutorial?

Pompedup commented 3 years ago

https://github.com/prisma/prisma-examples/tree/latest/typescript/graphql

josueadelima commented 3 years ago

Same here, I get this warning:

... with version 15.5.0, which doesn't satisfy what graphql-iso-date requests

Urigo commented 3 years ago

@Pompedup @josueadelima check out this commit and the comment at the top of the repo here:

The scalars defined in this repository have moved to the [GraphQL-scalars](https://www.graphql-scalars.dev) repository where they will be maintained.

Do you think that you would help report and update the tutorial to use the updated repo?

peacechen commented 3 years ago

@excitement-engineer this is still a problem

SMEETT commented 3 years ago

Just a bump. Support for GraphQL 15 would be great.

jhomarolo commented 2 years ago

I am encountering these problems too and seens to me the library is discontinued.

If the project owner does not object, I will create a new version of this lib using this as a base, but already with graphql 15 support

Urigo commented 2 years ago

@jhomarolo why not use graphql-scalars many date related scalars?

SMEETT commented 2 years ago

I just used a "GraphQLString" in the end to handle ISODate (while using a "DataTypes.DATE" in Sequelize) - this combination gives me all I need. Maybe that helps someone.

jlowcs commented 2 years ago

@jhomarolo why not use graphql-scalars many date related scalars?

There's actually a potential difference of behavior between SSR and CSR when using that: https://github.com/Urigo/graphql-scalars/discussions/957

otwm commented 2 years ago

Same goes for 16.3.0.

bahachammakhi commented 2 years ago

Issues with typescript

Type '{ type: GraphQLScalarType; }' is not assignable to type 'GraphQLFieldConfig<any, any, any>'. Types of property 'type' are incompatible. Type 'GraphQLScalarType' is not assignable to type 'GraphQLOutputType'.

geosigno commented 2 years ago

Any update? This is a blocker for me.

dremonkey commented 2 years ago

@geosigno move to https://github.com/Urigo/graphql-scalars. This project is discontinued according to the readme.