Do not close stderr to prevent issues

excitoon / video-remove-silence

Tool for removing silence from video files

MIT License

109 stars 23 forks source link

Do not close stderr to prevent issues #6

Closed eperez closed 4 years ago

valentijnscholten commented 4 years ago

I can confirm this fixes the Stream map '0:v:0' matches no streams. error seen on master branch

excitoon commented 4 years ago

Wow I wonder how my tool which I wrote to transform only 1 set of video, became relatively popular. @eperez I guess it's better to redirect it to subprocess.DEVNULL once we don't process it anyway. Can you explain why not closing stderr is better? And what shall ffmpeg do if pipe gets overflowed?