search

excln / BmsONE

an editor for bmson files.
23 stars 3 forks source link

Removing a note on key lane during keysound playback causes a crash. #9

Closed TomoAlien closed 6 years ago

TomoAlien commented 7 years ago

BmsONE 0.1.5 crashes when you remove a keysound while it's playing back and it's on the key lane. This doesn't happen to keysounds located on a BGM lane.

The easiest way to reproduce it is to create/edit a note on a key lane (which will play it back), then remove it during the playback. This consistently causes a crash.

DolphinDTM commented 7 years ago

I think this error is referenced here: https://github.com/excln/BmsONE/issues/4

excln commented 7 years ago

I couldn't reproduce it on neither Windows nor Mac. Does it happen with any bmson? Is Master Cache enabled?

TomoAlien commented 7 years ago

Yes, it happens on any bmson, and with master cache both disabled and enabled.

Here's a video of the bug in action: https://www.youtube.com/watch?v=zu_HcGOxiRw

excln commented 7 years ago

OK, I finally reproduced it. It happens only on right clicking (not pressing Delete key) on the note in Write Mode regardless of the playback. It's been already fixed in the master branch. Please check the next release.

excln commented 6 years ago

Fixed at beta 0.2.1.