search

excubo-ag / WebCompiler

Apache License 2.0
149 stars 30 forks source link

Stop webcompiler from touching source files #28

Closed aarivex closed 3 years ago

aarivex commented 3 years ago

First of all I'd like to say that I really like this project because its simple and provides a neat alternative to Node/npm solutions, as a lot of them just add more complexity and are often painful to configure, especially for the first time.

I set up my project file so that it runs webcompiler on every build, and it works flawlessly. Though there is something that bugs me - the source file, at least the .scss file, is getting edited.

Every time I run webcompiler, the indentation of the source file is being trimmed and a sourceMap comment appears in the last line. Example:

body {
  background: #fafafa; }
/*# sourceMappingURL=resources\css\app.css.map */

Is there a way to disable this behavior?

Thanks.

stefanloerwald commented 3 years ago

Hi @aarivex,

normally this should be possible by adjusting the SourceMap feature of the sass compiler. See the configuration section in this project's Readme. However, I just noticed that there is a bug in our code that made this setting be ignored for the sass compilation step. A new version (2.6.10) will be available in a few minutes fixing this.

BR Stefan

aarivex commented 3 years ago

Hi!

Thanks for the response and update. I initially had disabled the SourceMap property in the configuration file, yet it was ignored as you stated.

Update: I noticed that creating a default configuration file using --defaults comes with the SourceMap property already disabled.

stefanloerwald commented 3 years ago

Hi,

is it working as expected with v2.6.10 now?

Thanks for your feedback Stefan

aarivex commented 3 years ago

I don't know what happened, but strangely it doesn't override my source file anymore. Its still the same version.

I'll further evaluate and get back to you soon! Thanks.

aarivex commented 3 years ago

I can't track why it suddenly stopped changing the source file.

I'll just update to the latest version. Really weird.

stefanloerwald commented 3 years ago

Hi @aarivex,

is this issue resolved or are you continuing to experience this unwanted behaviour?

Thanks for your feedback Stefan

aarivex commented 3 years ago

Hey!

I gladly didn't face any issues yet. Thanks for checking!