search

excubo-ag / WebCompiler

Apache License 2.0
149 stars 30 forks source link

dart-sass support #37

Closed Liero closed 1 year ago

Liero commented 3 years ago

Hi,

just FYI, there is a preview 2 release of DartSassHost.

It would be great, if you could test it out. Thanks

stefanloerwald commented 3 years ago

Hi @Liero,

Thanks for getting in touch. I am aware of DartSassHost and awaiting the first non-preview release. I've already experimented with DartSassHost and everything is looking good. For now, things will stay in PR stage (https://github.com/excubo-ag/WebCompiler/pull/38). I don't think the project should depend on a preview version of any package.

BR Stefan

Liero commented 3 years ago

I don't think the project should depend on a preview version of any package.

Definitely not, but you could theoretically release a preview version as well. The point is to find potential bugs in DartSassHost before final release and this is best way, IMO

stefanloerwald commented 3 years ago

I don't think the project should depend on a preview version of any package.

Definitely not, but you could theoretically release a preview version as well. The point is to find potential bugs in DartSassHost before final release and this is best way, IMO

Good idea, I'll do that!

stefanloerwald commented 3 years ago

I'm getting build failures (https://github.com/excubo-ag/WebCompiler/runs/3192991097?check_suite_focus=true), probably more related to net6 than to dartsass. I'll have to investigate, so the release of the first preview version might be a while.

stefanloerwald commented 3 years ago

@Taritsyn was able to help me with the issue I was experiencing (https://github.com/Taritsyn/DartSassHost/issues/2), which means v3.0.0-preview-1 is now available.

Liero commented 1 year ago

DartSassHost is stable now