search

excubo-ag / WebCompiler

Apache License 2.0
148 stars 29 forks source link

Fix #51 to also split dependent files string on newlines #52

Open JustinStolle opened 2 years ago

JustinStolle commented 2 years ago

Update to SassCompiler.cs. In the case of an inline comment in an import line, splitting the string only by ", will inadvertently skip over the files listed after the comment. So we shall split by newlines as well.

stefanloerwald commented 2 years ago

Thanks for this, @JustinStolle!

Would you mind also adding a unit test for this?

Thanks Stefan

JustinStolle commented 2 years ago

I would happily do so; however, it would require testing one or two private methods (GetFileInfos and possibly GetDependencies). I'm not sure what approach you might prefer to do that. Make them public or some other way?

stefanloerwald commented 2 years ago

Making them public is perfectly fine. If you feel like putting stuff into a separate helper class, that's fine for me as well. Thanks!

devjklein commented 10 months ago

@stefanloerwald @JustinStolle Any updates on getting this merged in? I saw the incident is closed but this issue still comes up.

stefanloerwald commented 10 months ago

I suspect that JustinStolle abandoned this, as the last interaction here was a long time ago. I'm fine with having this change merged, but really would like to see tests for this. Would you like to take over, @devjklein?