Closed alifeofkaizen closed 2 years ago
Hi @kaizen365,
Thanks for this contribution. Could you please add unit tests to this PR?
Thanks Stefan
No problems @stefanloerwald will do (on my windows machine) - Looks like the tests don't run under apple silicon interestingly enough.. (quick google seems to indicate possible arm support issue here with the jsengine)
@stefanloerwald for your review, thanks!
Thanks @kaizen365 for this! Most comments are very nitpicky. I'd appreciate if you could fix these and then I'm sure we can merge early next week.
No problems at all @stefanloerwald! Updated accordingly
Thank you for the contribution! Deployment is on it's way.
Thanks @stefanloerwald I made a mistake in the PR and creating a new one now, Issue was that in the README.MD file I specified a trailing slash for the IgnoreFolder variables, but this wasn't the case in the Unit Test. Thus, folders weren't being ignored if there was a trailing slash!
Have fixed this and also introduced Sub Folder ignore support. Just creating a PR and testing now.
Sometimes I want to exclude certain files and/or folders from being compiled when using recursive mode. This may be due to not wanting the contents of bin/obj folders being compiled, client libraries via libman compiled or even scss files which only contain variables (thus throwing an content error).