search

excubo-ag / WebCompiler

Apache License 2.0
148 stars 29 forks source link

IgnoreFolder now supports Trailing Slash and Ignoring Sub Folders #57

Closed alifeofkaizen closed 2 years ago

alifeofkaizen commented 2 years ago

This PR corrects a mistake in #53 whereby the README.MD specified to have a trailing / but the Unit Test did not (which passes) and in addition allows support to exclude sub folders by specifying * wildcard (this is a quick implementation - we can consider using File Globbing support in future 😅).

Test run for /workspaces/WebCompiler/Tests_WebCompiler/bin/Debug/net6.0/Tests_WebCompiler.dll (.NETCoreApp,Version=v6.0)
Microsoft (R) Test Execution Command Line Tool Version 17.0.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

Passed!  - Failed:     0, Passed:    50, Skipped:     0, Total:    50, Duration: 13 s - /workspaces/WebCompiler/Tests_WebCompiler/bin/Debug/net6.0/Tests_WebCompiler.dll (net6.0)
stefanloerwald commented 2 years ago

Thanks for the fix. I think supporting just suffixes with an asterisk is probably misleading to users who would expect that to work anywhere, just like globbing. I think it's better to split globbing into a separate PR and undo the suffix support here. Do you agree?

alifeofkaizen commented 2 years ago

Makes sense @stefanloerwald - I've created #58 accordingly for your review