search

excubo-ag / WebCompiler

Apache License 2.0
148 stars 29 forks source link

Support Trailing Slash in IgnoreFolder variables #58

Closed alifeofkaizen closed 2 years ago

alifeofkaizen commented 2 years ago

This PR corrects a mistake in #53 whereby the README.MD specified to have a trailing / but the Unit Test did not (which passes). Unit Tests have also been added to verify that Sub Folders are not ignored unless explicitly mentioned in the Ignore Folders variable.

Per comment on #53, a future PR will be created to support File Globbing.

@kaizen365 ➜ /workspaces/WebCompiler (feature/ignorefolder-trailing-slash) $ dotnet test
  Determining projects to restore...
  All projects are up-to-date for restore.
  WebCompiler -> /workspaces/WebCompiler/WebCompiler/bin/Debug/net6.0/Excubo.WebCompiler.dll
  Tests_WebCompiler -> /workspaces/WebCompiler/Tests_WebCompiler/bin/Debug/net6.0/Tests_WebCompiler.dll
Test run for /workspaces/WebCompiler/Tests_WebCompiler/bin/Debug/net6.0/Tests_WebCompiler.dll (.NETCoreApp,Version=v6.0)
Microsoft (R) Test Execution Command Line Tool Version 17.0.0
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.

Passed!  - Failed:     0, Passed:    50, Skipped:     0, Total:    50, Duration: 13 s - /workspaces/WebCompiler/Tests_WebCompiler/bin/Debug/net6.0/Tests_WebCompiler.dll (net6.0)
stefanloerwald commented 2 years ago

Thanks for this. I'm wondering if this PR is actually necessary since #59 is going to remove the distinction between folder and file?

alifeofkaizen commented 2 years ago

Thanks for this. I'm wondering if this PR is actually necessary since #59 is going to remove the distinction between folder and file?

Agreed, I'll close this PR. Please re-open if not ok,