search

exebetche / vlsub

VLC extension to download subtitles from opensubtitles.org
1.35k stars 346 forks source link

A lot of version number mismatch #107

Closed scootergrisen closed 9 years ago

scootergrisen commented 9 years ago

VLC 2.2.1 includes VLsub extension version 0.9.13.

Go to VLC : View > Download Subtitles. Says 0.9 in the dialog title.

Search for "vlsub" in the VLC "Plugins & Extensions" dialog... In the list is says: Version 0.9.8

Install it and go to "Active Extensions" tab, the one i just installed says "VLsub 0.9.10".

exebetche commented 9 years ago

You should say that to the Vlc team, I'm not managing the serving providing the "Plugins & Extensions" service, only this repository.

scootergrisen commented 9 years ago

What about the dialog title that says VLSub 0.9.

In the code it says "VLSub 0.9", it dont know if that is used for the dialog title:

conf = { url = "http://api.opensubtitles.org/xml-rpc", path = nil, userAgentHTTP = "VLSub", useragent = "VLSub 0.9", translations_avail = {}, downloadBehaviours = nil, languages = languages },

exebetche commented 9 years ago

Yes this is the version 0.9, it is called a major version. I didn't want to obfuscate the menu with the minor version "0.9.13" which is too long.

scootergrisen commented 9 years ago

Maybe remove the version number from the dialog title and also remove it from the extension title in Plugins & Extensions dialog.

People can click the extension to show more info about it.