exebetche / vlsub

VLC extension to download subtitles from opensubtitles.org
1.34k stars 346 forks source link

Extension doesn't open when opened second time OS X #121

Closed jelen-dev closed 8 years ago

jelen-dev commented 8 years ago

Hi, I am running VLC player v 2.2.1 VLSub v 0.9.13 and when I load extension 1st time (after quitting the VLC) it loads as expected but once I try to open it again it just doesn't load. 3rd attempt will load it again 4th doesn't 5th will load it again etc.. So it is always needed to load it twice to (I guess) force close the previous instance and then open new one. Seems like there is some problem with quitting the extension when it is closed by "close" button maybe? I am using OS X 10.11.1 but the problem was the same on 10.10 and previous versions of VLC and VLCSub extensions (I had like 2 OS X major updates, 2-3 VLC versions and 2-3 VLC Sub versions)

jelen-dev commented 8 years ago

Maybe it is related to this issue: https://github.com/exebetche/vlsub/issues/71

sbornia commented 8 years ago

This is also happening on my end. OSX 10.11.3, VLC 2.0.8, VLSub 0.9.13

Aigrefin commented 8 years ago

I tried on my OSX, and this fixes the bug : #131

exebetche commented 8 years ago

Should be fixed by PR #131