exebetche / vlsub

VLC extension to download subtitles from opensubtitles.org
1.34k stars 346 forks source link

Plugin stopped working #175

Open JD719 opened 7 years ago

JD719 commented 7 years ago

Hi, I'm aware opensubtitles made changes in their end yesterday, from there vlsub stopped working. It hangs on "searching subtitles"

Debian 9.0 VLC 2.2.5 VLSub 0.9

This is the log I was able to capture running VLC from CLI

[00007fbe44001638] http access error: error: HTTP/1.1 522 Origin Connection Time-out [00007fbe48c9be78] http access error: error: HTTP/1.1 522 Origin Connection Time-out [00007fbe48c9be78] http access error: error: HTTP/1.1 522 Origin Connection Time-out [00007fbe44001638] http access error: error: HTTP/1.1 522 Origin Connection Time-out [00007fbe44001638] access_mms access error: error: HTTP/1.1 522 Origin Connection Time-out [00007fbe44000958] core art finder error: no suitable access module for http://services.tvrage.com/feeds/search.php?show=Black Sails' [00007fbe48c9be78] access_mms access error: error: HTTP/1.1 522 Origin Connection Time-out [00007fbe4800fa28] core art finder error: no suitable access module forhttp://services.tvrage.com/feeds/search.php?show=Black Sails'

harrierbird commented 7 years ago

yeah, I am having the same problem. Search results = 0. Either that or it crashes.

varjolintu commented 7 years ago

Version 0.9? Why don't you try if it happens with the latest version?

JD719 commented 7 years ago

@varjolintu 0.9 is the latest version available in my distro repo. Isn't vlsub pushing updates to debian anymore?

varjolintu commented 7 years ago

@JD719 I really don't now about Debian repo's. The VLC addon page is out of date, so the repo should be updated from the github. Still, it shows 24 commits after the last release so..

JD719 commented 7 years ago

ok I just downloaded the last available version, now I get the same result as @harrierbird 0 results

varjolintu commented 7 years ago

What changes did opensubtitles made? I couldn't find them. I tested the plugin today and it worked normally.

I think this has something to do with the tvrage fetcher extension that downloads some metadata.

JD719 commented 7 years ago

It's not clear to me, their explanations are pretty vague You can get some info here: http://forum.opensubtitles.org/viewforum.php?f=1

harrierbird commented 7 years ago

Thank you @JD719. I was starting to think I was the only one having this problem with the new VLSub version. I use what I think is the latest one, v0.10.2.

JD719 commented 7 years ago

I should specify something, the feature that is not working is the "search by hash" one, the one I always used. Search by name seems to work, but it is way less reliable in my experience.

varjolintu commented 7 years ago

The reason the plugin works for me is probably that the metadata scripts are not ran at all:

core debug: looking for meta fetcher module matching "any": 1 candidates lua debug: Trying Lua scripts in /Users/humanoid/Library/Application Support/org.videolan.vlc/lua/meta/fetcher lua debug: Trying Lua scripts in /Applications/VLC.app/Contents/MacOS/share/lua/meta/fetcher lua debug: Trying Lua playlist script /Applications/VLC.app/Contents/MacOS/share/lua/meta/fetcher/tvrage.luac lua debug: skipping script (unmatched scope) /Applications/VLC.app/Contents/MacOS/share/lua/meta/fetcher/tvrage.luac lua debug: Trying Lua scripts in /Applications/VLC.app/Contents/MacOS/share/share/lua/meta/fetcher core debug: no meta fetcher modules matched

Is there any difference if you open the VLC Preferences and uncheck the checkbox which reads "Allow metadata network access"?

harrierbird commented 7 years ago

I use "Search by name" and mysteriously, this now works again... O.o

JD719 commented 7 years ago

@varjolintu I'm afraid it makes no difference for me. @harrierbird yes as I stated before it works for me too, but searching by name is kinda sad, the chances you get a synchronized sub file decrease drastically.

varjolintu commented 7 years ago

For me it seems that the OpenSubtitles is limiting the API requests for some reason.

@JD719, have you tried to remove the tvrage.luac script from VLC? Does it make a difference?

JD719 commented 7 years ago

@varjolintu it does not make difference

marsjaninzmarsa commented 7 years ago

@JD719: Are you sure that you're using newest version of VLSub? VLC can load extensions from many locations, and sometimes more than one version of extension can be loaded at the same time. zrzut ekranu z 2017-04-13 13 20 58

JD719 commented 7 years ago

@marsjaninzmarsa yes I'm using 0.10.2. I actually deleted the old one. Do you get results searching by hash?

harrierbird commented 7 years ago

@JD719 I am using 0.10.2 and I get results searching by hash, even if it's just one. What happened to me seemed to be something temporary. It eventually went away without doing anything. Not sure what is happening to you though.

JD719 commented 7 years ago

@harrierbird what OS are you running VLC on?

harrierbird commented 7 years ago

@JD719 macOS Sierra 10.12.14

pdrocaldeira commented 7 years ago

Not working for me, using 0.10.2. :(

Arch Linux .

marsjaninzmarsa commented 7 years ago

@JD719 worksforme, VLSub 0.10.2 and 0.10.1, VLC 2.2.4, LMDE2 and Windows 7 (3 machines total).

Are you logged in? OS was known for limiting unauthenticated API calls.

JD719 commented 7 years ago

After a few days downloading subs manually, today I did a search within the plugin and got one result at least, I used to get 3 at least for series like this one. It must be something in OS end they screwed.

@marsjaninzmarsa no I'm not using credentials, never did it, anyway if I log in the result is the same.