exebetche / vlsub

VLC extension to download subtitles from opensubtitles.org
1.34k stars 345 forks source link

an working for ver 3+ #221

Open CoLdAs1cE opened 5 years ago

CoLdAs1cE commented 5 years ago

https://github.com/videolan/vlc/tree/master/share/lua/extensions

M4CC commented 5 years ago

I don't understand why VLSub still hasn't been integrated with VLC for Mac. It's already part of it on Windows.

CoLdAs1cE commented 5 years ago

if you want hotkey it is possible but u can not start the vlsub in 1 hotkey. U have to use the 2 hotkeys to get to the vlsub window. But u will still have to select sub with mouse then use hotkey to close the vlsub so its kind of useless in my opinion ;), so u have to use like 3-5 hotkeys to do this. And u have to edit the code to get hotkeys

CoLdAs1cE commented 5 years ago

ops wrong button

CoLdAs1cE commented 5 years ago

@M4CC i dont even even know if it comes with windows, but they do have it in their github, so it should come with mac and pc and linux i think

or mby its nightly's if they still do those

Neobond commented 5 years ago

With 3.0.4 VLSub 0.11.0 causes the player to crash almost every time when looking for subtitles doesn't matter if it's by hash or by name, but it is extremely frustrating. I guess we live in a world where quality is no longer important anymore.

Tiwas commented 5 years ago

With 3.0.4 VLSub 0.11.0 causes the player to crash almost every time when looking for subtitles doesn't matter if it's by hash or by name, but it is extremely frustrating. I guess we live in a world where quality is no longer important anymore.

Wow! Way to make the people spending their free time coding feeling good about making an effort for the rest of us! Did you make sure this is not a VLC issue? Or maybe local for your computer? Or how about fixing it yourself instead of just being downright nonconstructive in your criticism?

CoLdAs1cE commented 5 years ago

this works fine, with the occasionally crash. think my windows needs reset

@Neobond btw this is not the script on git, its link to the official vlc git this script crashes no matter what in vlc 3

kid1412621 commented 5 years ago

same here

Neobond commented 5 years ago

The build in one with 3.0.7.1 works fine now.

CoLdAs1cE commented 5 years ago

good :D