search

execuc / LCInterlocking

FreeCAD module to create laser cut interlocking parts.
GNU Lesser General Public License v2.1
140 stars 31 forks source link

Crosspiece shall allow objects of different height #43

Open euphi opened 3 years ago

euphi commented 3 years ago

Is it not possible to create a crosspiece of two parts of different height, because this raises a "not managed" exception:

Traceback (most recent call last):
  File "/home/ian/.FreeCAD/Mod/LCInterlocking/panel/crosspiece.py", line 54, in onChanged
    self.execute(fp)
  File "/home/ian/.FreeCAD/Mod/LCInterlocking/panel/crosspiece.py", line 136, in execute
    computed_parts = make_cross_parts(parts)
  File "/home/ian/.FreeCAD/Mod/LCInterlocking/lasercut/crosspart.py", line 372, in make_cross_parts
    else:
<class 'ValueError'>: Not managed

However, it is easily possible to create such a crosspiece. I just added the call to remove_intersections(first_part, second_part, referential_faces, axis) also for the "not managed" case and the result is fine (with the first part higher than the second one)

Freecad-LCInterlocking-Screenshot_20201004_204608

Obviously this is not the clean solution, but I don't really understand the different cases in make_cross_parts(parts), so I can't create a better solution.

execuc commented 3 years ago

Hello, I think I put this case aside and never came back to it ! Thank you for this use case and your solution. I will watch as soon as possible.

jvanbruegge commented 12 months ago

Just hit this as well and replacing the Not manged error with remove_intersections(first_part, second_part, referential_faces, axis) in lasercut/crosspart.py worked for me as well