execuc / LCInterlocking

FreeCAD module to create laser cut interlocking parts.
GNU Lesser General Public License v2.1
144 stars 33 forks source link

Slot width tolerance wrong way around #44

Closed Tectu closed 3 years ago

Tectu commented 4 years ago

I'm experiencing issues with the Slot width tolerance setting of the tab feature.

It seems like the the slot width tolerance is applied "the wrong way around". Instead of the slot being wider than the tab (or the tab shorter than the slot) I end up with tabs that are too wide. After applying the operation the tabs are made wider by the amount specified in the slot width tolerance parameter.

I imagined that specifying a negative slot width tolerance would be a sufficient workaround but the field only accepts positive numbers.

I'm experiencing this issue with FreeCAD 0.18.4 and 0.19.22.

Am I missing something / doing something wrong?

execuc commented 4 years ago

Hello, I did a test and it seems to work as you specify it. When I increase the "Slot width tolerance" parameter of the part, the slot width increases while the tab remains the same. Attached is a screenshot with a high value (5mm).

tab_slot_tolerance

There is the opposite behavior when I increase the "laser beam diameter" parameter, wouldn't there be a shift in the parameters (from the interface) ?

Tectu commented 3 years ago

I can confirm that this is working as intended. The issue I described arises when the slot width tolerance is smaller than the laser beam diameter value.