search

executablebooks / .github

Community health files: Contributing guidelines, Code of Conduct, ...
MIT License
4 stars 8 forks source link

Update CONTRIBUTING.md #5

Closed chrisjsewell closed 4 years ago

chrisjsewell commented 4 years ago

Change ✏️ REWRITE to 👀 REVISE Not sure what the best emoji+keyword is for this? but its basically for minor things that should not show up directly in a changelog, like typos or very minor code changes (i.e. nothing that users/developers would really care about) I would call it NITPICK, but people who have made PRs might not appreciate this wording for their commit lol

e.g. I would have used this for https://github.com/executablebooks/sphinx-book-theme/pull/150#issuecomment-669979005 and https://github.com/executablebooks/sphinx-book-theme/pull/155

welcome[bot] commented 4 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

choldgraf commented 4 years ago

lol or we could have an undocumented PR tag for when we want to be passive aggressive: 🚲 BIKESHED:

but seriously - "REVISE" is fine with me. In other projects we have just used a generic 🔧 MAINT: that lumps in "REVISE" and "REFACTOR" under general maintenance category. But if we wanna keep them separate, I'm fine w/ revise.

welcome[bot] commented 4 years ago

Congrats on your first merged pull request in this project! :tada: congrats
Thank you for contributing, we are very proud of you! :heart:

choldgraf commented 4 years ago

I love this fish

pradyunsg commented 4 years ago

NITPICK, but people who have made PRs might not appreciate this wording for their commit lol

😂

FWIW, I certainly would've called it that!