executablebooks / MyST-NB

Parse and execute ipynb files in Sphinx
https://myst-nb.readthedocs.io
BSD 3-Clause "New" or "Revised" License
201 stars 81 forks source link

could you make a release ? #543

Closed 12rambau closed 7 months ago

12rambau commented 9 months ago

V0.17.2 is still blocked on Sphinx<6 making many pipelines (including pydata-sphinx-theme) crash

welcome[bot] commented 9 months ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

agoose77 commented 9 months ago

We're working through some parts of the CI pipeline, and one these are fixed, we'll make a release!

cisaacstern commented 9 months ago

V0.17.2 is still blocked on Sphinx<6 making many pipelines (including pydata-sphinx-theme) crash

+1 on this exact issue. Trying to update our Pangeo Forge docs in https://github.com/pangeo-forge/pangeo-forge-recipes/pull/610 is also blocked by this. Will very much appreciate a release as soon as you are able. 🙏

cisaacstern commented 9 months ago

We're working through some parts of the CI pipeline, and one these are fixed, we'll make a release!

@agoose77 is there an open Issue or PR for this? Would be curious to see if there's some way I can assist, or at least follow along with the progress.

peytondmurray commented 8 months ago

I'd really like to help out in any way I can to push this issue forward, but I'd really like to avoid spamming the maintainers in the process. It looks like the one remaining issue here is a typo that is aggravating pre-commit:

image

Normally I'd prefer not to make PRs related to this kind of thing. Seeing as how it is holding up a release, I'd be happy to do so here if it means we can get a release out.

agoose77 commented 8 months ago

My bandwidth is pretty tied up this week. AFAICR, we're just needing to fix-up some type hints, and then we're good to go.

peytondmurray commented 8 months ago

Sounds good - if you point me in the direction of a specific issue, I can take care of it, though it looks like mypy is currently passing. I'd be happy to include the fix for the typo above in whatever else needs to be done.

PhilipVinc commented 8 months ago

@agoose77 I think the repo's ready for a new release now. Could you tag 0.18?

njzjz commented 8 months ago

If 0.18.0 is not available, could you tag 0.18.0b0?

sphuber commented 8 months ago

A new release would be great as it would also loosen the requirement on myst-parser to >=0.18.0 which is necessary to be able to install 2.0.0 which is required for compatibility with Python 3.12

agoose77 commented 8 months ago

Hi all - could you try out https://pypi.org/project/myst-nb/1.0.0rc0/?

sphuber commented 8 months ago

Works for our build of AiiDA :+1: thanks a lot!

cisaacstern commented 8 months ago

Thanks @agoose77! LGTM over in https://github.com/pangeo-forge/pangeo-forge-recipes/pull/641 👍

PhilipVinc commented 8 months ago

@agoose77 I tested the rc0 on our documentation of https://readthedocs.org/projects/netket/and it works great. We're just waiting for an official release of 1.0.0 to update our infrastructure.

jakevdp commented 8 months ago

I tested rc0 on the documentation build for http://github.com/google/jax, and everything looks fine. Thanks for all the work on this package!

blakeNaccarato commented 7 months ago

Thanks for releasing v1.0.0! Looks like this issue may be able to be closed now.

It seems there isn't a changelog entry yet, but from the diff (https://github.com/executablebooks/MyST-NB/compare/v0.17.2...v1.0.0), the biggest user-facing changes seem to be Sphinx 7 support, bumping minimum myst-parser to 1.0, removing upper version pins in requirements, and bumping minimum Python to 3.9. Are there any other major changes to watch out for when updating? Thanks again!

agoose77 commented 7 months ago

This has now been handled!

@blakeNaccarato you're correct that the major changes are removing caps, bumping dependencies, and adding Sphinx 7 support. :)