search

executablebooks / MyST-NB

Parse and execute ipynb files in Sphinx
https://myst-nb.readthedocs.io
BSD 3-Clause "New" or "Revised" License
211 stars 84 forks source link

MAINT: fix sphinx 8.0 compatibility #620

Closed bsipocz closed 2 months ago

bsipocz commented 3 months ago

It's beyond the scope for this PR, but I would also suggest adding a job that pulls the development versions of dependencies, even if it's just in a job that runs from a e.g. weekly cron; so end users would not run into incompatibilities when an upstream release is out.

(We do this for sphinx extensions and pytest plugins; as well as for libraries that more and more test against nightly wheels; and it's really nice from the release manager perspective as it removes a lot of cases for a rushed compatibility release).

Closes #619

bsipocz commented 3 months ago

OK, well, this was naive 😅 (but was passing locally)

agoose77 commented 2 months ago

@bsipocz thanks for this, LGTM! I'll auto-merge and then see where we get to.

bsipocz commented 2 months ago

@agoose77 - Thanks! As I see it still needs an actual review approval for the auto merge to kick in.

EwoutH commented 2 months ago

Thanks a lot for this PR!

Could a new release be tagged which includes this PR?