executablebooks / MyST-Parser

An extended commonmark compliant parser, with bridges to docutils/sphinx
https://myst-parser.readthedocs.io
MIT License
738 stars 196 forks source link

πŸ‘Œ IMPROVE: Substitution extension #777

Closed chrisjsewell closed 1 year ago

chrisjsewell commented 1 year ago

Allow any value type (including dict, list, datetime) and emit a myst.substitution warning for errors in resolving the substitution.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.23 :tada:

Comparison is base (b043351) 90.00% compared to head (e639ce7) 90.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #777 +/- ## ========================================== + Coverage 90.00% 90.23% +0.23% ========================================== Files 23 23 Lines 2970 2970 ========================================== + Hits 2673 2680 +7 + Misses 297 290 -7 ``` | Flag | Coverage Ξ” | | |---|---|---| | pytests | `90.23% <100.00%> (+0.23%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/executablebooks/MyST-Parser/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | Coverage Ξ” | | |---|---|---| | [myst\_parser/config/dc\_validators.py](https://app.codecov.io/gh/executablebooks/MyST-Parser/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#diff-bXlzdF9wYXJzZXIvY29uZmlnL2RjX3ZhbGlkYXRvcnMucHk=) | `83.63% <100.00%> (+0.30%)` | :arrow_up: | | [myst\_parser/config/main.py](https://app.codecov.io/gh/executablebooks/MyST-Parser/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#diff-bXlzdF9wYXJzZXIvY29uZmlnL21haW4ucHk=) | `86.26% <100.00%> (ΓΈ)` | | | [myst\_parser/mdit\_to\_docutils/base.py](https://app.codecov.io/gh/executablebooks/MyST-Parser/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#diff-bXlzdF9wYXJzZXIvbWRpdF90b19kb2N1dGlscy9iYXNlLnB5) | `93.41% <100.00%> (+0.72%)` | :arrow_up: | | [myst\_parser/warnings\_.py](https://app.codecov.io/gh/executablebooks/MyST-Parser/pull/777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#diff-bXlzdF9wYXJzZXIvd2FybmluZ3NfLnB5) | `96.22% <100.00%> (+0.07%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

firasm commented 1 year ago

Thank you, this is great!!