Closed agoose77 closed 8 months ago
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
b445a0c
) 90.08% compared to head (80e4b6a
) 90.04%.
Files | Patch % | Lines |
---|---|---|
myst_parser/mdit_to_docutils/base.py | 66.66% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Cheers @agoose77!
Note some suggestions on a fix were given here: https://github.com/executablebooks/MyST-Parser/issues/612#issuecomment-1265047994, maybe you want to double check that against your changes here?
Will have a proper look later
Thanks @chrisjsewell — I actually used that issue as a starting point. As such, I'm hopeful that this should fall in line with the recommended changes where possible.
Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart:
This PR fixes the deprecation warnings raised by docutils' deprecation of
OptionParser
.The help handling is a little ugly - we could introduce a switch on the docutils version like we do for the default settings. However, I think this approach will be less likely to break once the breaking change is introduced.