Closed danieleades closed 4 months ago
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:
Attention: Patch coverage is 72.22222%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 90.06%. Comparing base (
c3fa3db
) to head (8d99f4e
).
Files | Patch % | Lines |
---|---|---|
myst_parser/parsers/docutils_.py | 0.00% | 4 Missing :warning: |
myst_parser/mocking.py | 50.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Actually, I also reverted https://docs.astral.sh/ruff/rules/missing-trailing-comma/; I don't think it integrates well with the ruff formatter, in particular https://docs.astral.sh/ruff/settings/#format_skip-magic-trailing-comma (see also https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html#the-magic-trailing-comma)
lints are in separate commits for ease of reviewing (not every one of these lints will necessarily be of interest)