executablebooks / MyST-Parser

An extended commonmark compliant parser, with bridges to docutils/sphinx
https://myst-parser.readthedocs.io
MIT License
730 stars 192 forks source link

use pre-commit to format config files #863

Closed danieleades closed 6 months ago

danieleades commented 6 months ago

putting this here as a draft, because even if this is of interest discussion will be required to hammer out the specific configuration

danieleades commented 6 months ago

closing. not a fan of the way the autoformatting handles 4-space indents in yaml

chrisjsewell commented 6 months ago

Aha was just about to say hi, but yeh I think it's not a bad thing to have standardised formatting, but not super picky on the exact config

danieleades commented 6 months ago

Aha was just about to say hi, but yeh I think it's not a bad thing to have standardised formatting, but not super picky on the exact config

i'm all for standardising the formatting, but applying additional spaces on both sides of the hyphen when the indent is increased is pretty weird - https://github.com/executablebooks/MyST-Parser/pull/863/commits/38abd7147487412881d0fb05de2fe1a9f74b4c2d