executablebooks / MyST-Parser

An extended commonmark compliant parser, with bridges to docutils/sphinx
https://myst-parser.readthedocs.io
MIT License
730 stars 192 forks source link

use pathlib #864

Open danieleades opened 6 months ago

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.06%. Comparing base (e74769c) to head (cb24054).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #864 +/- ## ======================================= Coverage 90.06% 90.06% ======================================= Files 24 24 Lines 3372 3372 ======================================= Hits 3037 3037 Misses 335 335 ``` | [Flag](https://app.codecov.io/gh/executablebooks/MyST-Parser/pull/864/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | Coverage Δ | | |---|---|---| | [pytests](https://app.codecov.io/gh/executablebooks/MyST-Parser/pull/864/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | `90.06% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

chrisjsewell commented 4 months ago

heya @danieleades do you wanna fix the last few lints?:

myst_parser/inventory.py:410:10: PTH123 `open()` should be replaced by `Path.open()`
myst_parser/inventory.py:471:14: PTH123 `open()` should be replaced by `Path.open()`
myst_parser/mdit_to_docutils/base.py:1211:17: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator
myst_parser/mdit_to_docutils/sphinx_.py:68:17: PTH118 `os.path.join()` should be replaced by `Path` with `/` operator