search

executablebooks / MyST-Parser

An extended commonmark compliant parser, with bridges to docutils/sphinx
https://myst-parser.readthedocs.io
MIT License
708 stars 189 forks source link

👌 Improve directive parsing warnings #893

Closed chrisjsewell closed 3 months ago

chrisjsewell commented 3 months ago

Minor improvement to the specificity of warnings regarding problems encountered when parsing directives

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 80.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.06%. Comparing base (978e845) to head (ee4ae60).

Files Patch % Lines
myst_parser/parsers/directives.py 81.25% 3 Missing :warning:
myst_parser/mocking.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #893 +/- ## ========================================== + Coverage 90.04% 90.06% +0.02% ========================================== Files 24 24 Lines 3364 3372 +8 ========================================== + Hits 3029 3037 +8 Misses 335 335 ``` | [Flag](https://app.codecov.io/gh/executablebooks/MyST-Parser/pull/893/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | Coverage Δ | | |---|---|---| | [pytests](https://app.codecov.io/gh/executablebooks/MyST-Parser/pull/893/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | `90.06% <80.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.