Test regressions with Sphinx 7.3.7

[mgorny]

What version of myst-parser are you using?

707e8a4fd61df8c79ed0d589edb51dd9e23df53c

What version dependencies are you using?

pip list

``` Package Version ----------------------------- -------- alabaster 0.7.16 Babel 2.14.0 beautifulsoup4 4.12.3 certifi 2024.2.2 charset-normalizer 3.3.2 coverage 7.4.4 defusedxml 0.7.1 docutils 0.20.1 exceptiongroup 1.2.1 idna 3.7 imagesize 1.4.1 iniconfig 2.0.0 Jinja2 3.1.3 linkify-it-py 2.0.3 markdown-it-py 3.0.0 MarkupSafe 2.1.5 mdit-py-plugins 0.4.0 mdurl 0.1.2 myst-parser 2.0.0 packaging 24.0 pip 24.0 pluggy 1.5.0 Pygments 2.17.2 pytest 8.1.1 pytest-cov 5.0.0 pytest-datadir 1.5.0 pytest_param_files 0.6.0 pytest-regressions 2.5.0 PyYAML 6.0.1 requests 2.31.0 ruamel.yaml 0.18.6 ruamel.yaml.clib 0.2.8 setuptools 69.1.1 snowballstemmer 2.2.0 soupsieve 2.5 Sphinx 7.3.7 sphinx_pytest 0.2.0 sphinxcontrib-applehelp 1.0.8 sphinxcontrib-devhelp 1.0.6 sphinxcontrib-htmlhelp 2.0.5 sphinxcontrib-jsmath 1.0.1 sphinxcontrib-qthelp 1.0.7 sphinxcontrib-serializinghtml 1.1.10 tomli 2.0.1 uc-micro-py 1.0.3 urllib3 2.2.1 wheel 0.42.0 ```

What operating system are you using?

Linux

Describe the Bug

After upgrading Sphinx to 7.3.7, a handful of tests are failing. FWICS all due to miscellaneous changes in output:

FAILED tests/test_renderers/test_fixtures_sphinx.py::test_syntax_elements[298-Sphinx Role containing backtick:] - AssertionError: actual != expected (use --regen-file-failure)
FAILED tests/test_renderers/test_fixtures_sphinx.py::test_sphinx_directives[341-versionadded (`sphinx.domains.changeset.VersionChange`):] - AssertionError: actual != expected (use --regen-file-failure)
FAILED tests/test_sphinx/test_sphinx_builds.py::test_references_singlehtml - AssertionError: FILES DIFFER:
FAILED tests/test_sphinx/test_sphinx_builds.py::test_heading_slug_func - AssertionError: assert '\x1b[91mWARN...x1b[39;49;00m' == ''
FAILED tests/test_sphinx/test_sphinx_builds.py::test_gettext_html - AssertionError: FILES DIFFER:

Tracebacks

```pytb ============================================================== FAILURES =============================================================== _____________________________________ test_syntax_elements[298-Sphinx Role containing backtick:] ______________________________________ file_params = ParamTestData(line=298, title='Sphinx Role containing backtick:', description=None, content='{code}``a=1{`}``\n', expe...s="code">\n a=1{`}\n', index=22, fmt=, extra={}) sphinx_doctree_no_tr = @pytest.mark.param_file(FIXTURE_PATH / "sphinx_syntax_elements.md") def test_syntax_elements(file_params, sphinx_doctree_no_tr: CreateDoctree): sphinx_doctree_no_tr.set_conf({"extensions": ["myst_parser"]}) result = sphinx_doctree_no_tr(file_params.content, "index.md") > file_params.assert_expected(result.pformat("index"), rstrip_lines=True) E AssertionError: actual != expected (use --regen-file-failure) E --- /tmp/MyST-Parser/tests/test_renderers/fixtures/sphinx_syntax_elements.md:298 E +++ (actual) E @@ -1,4 +1,4 @@ E E E - E + E a=1{`} tests/test_renderers/test_fixtures_sphinx.py:25: AssertionError ________________________ test_sphinx_directives[341-versionadded (`sphinx.domains.changeset.VersionChange`):] _________________________ file_params = ParamTestData(line=341, title='versionadded (`sphinx.domains.changeset.VersionChange`):', description=None, content='`... New in version 0.2.\n', index=27, fmt=, extra={}) sphinx_doctree_no_tr = @pytest.mark.param_file(FIXTURE_PATH / "sphinx_directives.md") def test_sphinx_directives(file_params, sphinx_doctree_no_tr: CreateDoctree): # TODO fix skipped directives # TODO test domain directives if file_params.title.startswith("SKIP") or file_params.title.startswith( "SPHINX4-SKIP" ): pytest.skip(file_params.title) sphinx_doctree_no_tr.set_conf({"extensions": ["myst_parser"]}) pformat = sphinx_doctree_no_tr(file_params.content, "index.md").pformat("index") # see https://github.com/sphinx-doc/sphinx/issues/9827 pformat = pformat.replace('', "") # see https://github.com/executablebooks/MyST-Parser/issues/522 if sys.maxsize == 2147483647: pformat = pformat.replace('"2147483647"', '"9223372036854775807"') # changed in sphinx 7.1 (but fixed in 7.2) pformat = pformat.replace( 'classes="sig sig-object sig sig-object"', 'classes="sig sig-object"' ) pformat = pformat.replace( 'classes="sig-name descname sig-name descname"', 'classes="sig-name descname"' ) pformat = pformat.replace( 'classes="sig-prename descclassname sig-prename descclassname"', 'classes="sig-prename descclassname"', ) # changed in sphinx 7.2 (#11533) pformat = pformat.replace( ( 'no-contents-entry="False" no-index="False" ' 'no-index-entry="False" no-typesetting="False" ' ), "", ) > file_params.assert_expected(pformat, rstrip_lines=True) E AssertionError: actual != expected (use --regen-file-failure) E --- /tmp/MyST-Parser/tests/test_renderers/fixtures/sphinx_directives.md:341 E +++ (actual) E @@ -2,4 +2,4 @@ E E E E - New in version 0.2. E + Added in version 0.2. tests/test_renderers/test_fixtures_sphinx.py:104: AssertionError _____________________________________________________ test_references_singlehtml ______________________________________________________ app = , status = <_io.StringIO object at 0x7f6d4d0d5f30> warning = <_io.StringIO object at 0x7f6d4d0d65f0> get_sphinx_app_doctree = .read at 0x7f6d4d0d5900> get_sphinx_app_output = .read at 0x7f6d4d0d5d80> @pytest.mark.sphinx( buildername="singlehtml", srcdir=os.path.join(SOURCE_DIR, "references_singlehtml"), freshenv=True, confoverrides={"nitpicky": True}, ) def test_references_singlehtml( app, status, warning, get_sphinx_app_doctree, get_sphinx_app_output, ): """Test reference resolution for singlehtml builds.""" app.build() assert "build succeeded" in status.getvalue() # Build succeeded warnings = warning.getvalue().strip() assert warnings == "" # try: # get_sphinx_app_doctree(app, docname="index", regress=True) # finally: # get_sphinx_app_doctree(app, docname="index", resolve=True, regress=True) try: get_sphinx_app_doctree( app, docname="other/other", regress=True, replace={"other\\other.md": "other/other.md"}, ) finally: > get_sphinx_app_doctree( app, docname="other/other", resolve=True, regress=True, replace={"other\\other.md": "other/other.md"}, ) tests/test_sphinx/test_sphinx_builds.py:160: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ app = , docname = 'other/other', resolve = True, regress = True replace = {'other\\other.md': 'other/other.md'}, rstrip_lines = False, regress_ext = '.xml' def read( app, docname="index", resolve=False, regress=False, replace=None, rstrip_lines=False, regress_ext=".xml", ): if resolve: doctree = app.env.get_and_resolve_doctree(docname, app.builder) extension = f".resolved{regress_ext}" else: doctree = app.env.get_doctree(docname) extension = regress_ext # convert absolute filenames for node in findall(doctree)( lambda n: "source" in n and not isinstance(n, str) ): node["source"] = pathlib.Path(node["source"]).name doctree = doctree.deepcopy() # remove attrs added in sphinx 7.1 doctree.attributes.pop("translation_progress", None) for node in findall(doctree)(nodes.Element): node.attributes.pop("translated", None) if regress: text = doctree.pformat() # type: str for find, rep in (replace or {}).items(): text = text.replace(find, rep) if rstrip_lines: text = "\n".join([li.rstrip() for li in text.splitlines()]) > file_regression.check(text, extension=extension) E AssertionError: FILES DIFFER: E /tmp/pytest-of-mgorny/pytest-10/test_references_singlehtml0/test_sphinx_builds/test_references_singlehtml.resolved.xml E /tmp/pytest-of-mgorny/pytest-10/test_references_singlehtml0/test_sphinx_builds/test_references_singlehtml.resolved.obtained.resolved.xml E HTML DIFF: /tmp/pytest-of-mgorny/pytest-10/test_references_singlehtml0/test_sphinx_builds/test_references_singlehtml.resolved.obtained.resolved.diff.html E --- E +++ E @@ -3,18 +3,18 @@ E