search

executablebooks / cookiecutter-jupyter-book

Cookiecutter template for a simple jupyter book
https://executablebooks.github.io/cookiecutter-jupyter-book/
BSD 3-Clause "New" or "Revised" License
140 stars 53 forks source link

Support book URL and checking if user exists for GitLab #30

Open joelostblom opened 3 years ago

joelostblom commented 3 years ago

Minor suggestions, currently the book URL and user check is hardcoded to GitHub. Maybe there could be a choice in the beginning about which version control host to use (like with the end for the CI now). Then the rest of the options could be generic ("username", "ci", etc) and the host URL would be prefaced where needed.

Changing the url to gitlab also gives this warning so maybe binder should be turn off if gitlab is chosen (with a messge): WARNING: Currently Binder/JupyterHub repositories must be on GitHub, got https://gitlab.com/

welcome[bot] commented 3 years ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada: