search

executablebooks / github-activity

Simple markdown changelogs for GitHub repositories
https://github-activity.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
47 stars 11 forks source link

🔧 MAINT: _get_latest_tag should use the remote repo #52

Closed manics closed 3 years ago

manics commented 3 years ago

This was changed in https://github.com/executablebooks/github-activity/pull/45

Was that just for testing?

welcome[bot] commented 3 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

consideRatio commented 3 years ago

https://github.com/executablebooks/github-activity/pull/45#pullrequestreview-600194547

It wasn't only for testing, it was a compromise though and require us to do git fetch ahead of time to ensure we get remote tags to be found locally as well.

manics commented 3 years ago

Should the function signature be updated to remove org and repo, and also the doc string?

consideRatio commented 3 years ago

Should the function signature be updated to remove org and repo, and also the doc string?

Ah yes that would make sense! I love that it is a function with a prefix _ in the name. Updating its parameters and docstring makes a lot of sense.