Open manics opened 3 years ago
Example: JupyterHub was switched from master
to main
after 1.4.0
:
github-activity --target jupyterhub/jupyterhub --branch main --since 1.4.0
# 1.4.0...master@{2021-05-14}
([full changelog](https://github.com/jupyterhub/jupyterhub/compare/1.4.0...6be3160d7487bb362df7095f24454ef2814951fc))
## Merged PRs
- prepare to rename default branch to main [#3462](https://github.com/jupyterhub/jupyterhub/pull/3462) ([@minrk](https://github.com/minrk))
## Contributors to this release
...
github-activity --target jupyterhub/jupyterhub --branch master --since 1.4.0
# 1.4.0...master@{2021-05-14}
([full changelog](https://github.com/jupyterhub/jupyterhub/compare/1.4.0...77691ae4023e68ae0ef1a21ca5301bebb5107bc3))
## New features added
- Support Pagination in the REST API [#3413](https://github.com/jupyterhub/jupyterhub/pull/3413) ([@naatebarber](https://github.com/naatebarber))
## Enhancements made
- patch base handlers from both jupyter_server and notebook [#3437](https://github.com/jupyterhub/jupyterhub/pull/3437) ([@minrk](https://github.com/minrk))
## Bugs fixed
- define Spawner.delete_forever on base Spawner [#3454](https://github.com/jupyterhub/jupyterhub/pull/3454) ([@minrk](https://github.com/minrk))
## Maintenance and upkeep improvements
- ci: fix typo in environment variable [#3457](https://github.com/jupyterhub/jupyterhub/pull/3457) ([@consideRatio](https://github.com/consideRatio))
- avoid re-using asyncio.Locks across event loops [#3456](https://github.com/jupyterhub/jupyterhub/pull/3456) ([@minrk](https://github.com/minrk))
- ci: github workflow security, pin action to sha etc [#3436](https://github.com/jupyterhub/jupyterhub/pull/3436) ([@consideRatio](https://github.com/consideRatio))
- Remove handling of jupyterhub 0.8 oauth client ids [#3433](https://github.com/jupyterhub/jupyterhub/pull/3433) ([@minrk](https://github.com/minrk))
## Documentation improvements
- Fix documentation [#3452](https://github.com/jupyterhub/jupyterhub/pull/3452) ([@davidbrochart](https://github.com/davidbrochart))
## Contributors to this release
...
github-activity --target jupyterhub/jupyterhub --branch main --since 1.4.0
# 1.4.0...master@{2021-05-14}
([full changelog](https://github.com/jupyterhub/jupyterhub/compare/1.4.0...6be3160d7487bb362df7095f24454ef2814951fc))
## New features added
- Support Pagination in the REST API [#3413](https://github.com/jupyterhub/jupyterhub/pull/3413) ([@naatebarber](https://github.com/naatebarber))
## Enhancements made
- patch base handlers from both jupyter_server and notebook [#3437](https://github.com/jupyterhub/jupyterhub/pull/3437) ([@minrk](https://github.com/minrk))
## Bugs fixed
- define Spawner.delete_forever on base Spawner [#3454](https://github.com/jupyterhub/jupyterhub/pull/3454) ([@minrk](https://github.com/minrk))
## Maintenance and upkeep improvements
- ci: fix typo in environment variable [#3457](https://github.com/jupyterhub/jupyterhub/pull/3457) ([@consideRatio](https://github.com/consideRatio))
- avoid re-using asyncio.Locks across event loops [#3456](https://github.com/jupyterhub/jupyterhub/pull/3456) ([@minrk](https://github.com/minrk))
- ci: github workflow security, pin action to sha etc [#3436](https://github.com/jupyterhub/jupyterhub/pull/3436) ([@consideRatio](https://github.com/consideRatio))
- Remove handling of jupyterhub 0.8 oauth client ids [#3433](https://github.com/jupyterhub/jupyterhub/pull/3433) ([@minrk](https://github.com/minrk))
## Documentation improvements
- Fix documentation [#3452](https://github.com/jupyterhub/jupyterhub/pull/3452) ([@davidbrochart](https://github.com/davidbrochart))
## Other merged PRs
- prepare to rename default branch to main [#3462](https://github.com/jupyterhub/jupyterhub/pull/3462) ([@minrk](https://github.com/minrk))
## Contributors to this release
...
This seems pretty good to me! If @consideRatio is happy with the implementation I am 👍
I note that this is a Draft PR currently. I'll wait with code review until its a non-draft. @manics please ping me if its ready for review now or in the future!
I'm not sure how to add a test for this... maybe a dedicated branch we can run tests against for real?
If a branch is specified PRs are filtered by checking their PR base branch. This fails to pick up all PRs when multiple PRs are merged into one branch, followed by that branch being merged into the mainline via a single PR. It will also fail if a branch is renamed.
If the
--since
argument is a git ref (not a date) this will now be used to get a list of commits in the requested branch after--since
. The list of PRs is then filtered by checking whether the PR commit appears in this list of branch commits. If the commit history for merged PRs/branches is maintained this should ensure PRs merged into one branch that are subsequently merged altogether into another branch are picked up.If
--since
is a date the current behaviour is kept since a commit date is not the same as the date the commit was added to a repo, so the only alternative is to fetch the list of all commits.Closes https://github.com/executablebooks/github-activity/issues/50
Todo: