executablebooks / github-activity

Simple markdown changelogs for GitHub repositories
https://github-activity.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
47 stars 11 forks source link

[ENH] include reviewers and committers in contributor list #65

Closed minrk closed 1 year ago

minrk commented 2 years ago

The most important part of this is done: getting the reviewer list and committer list from graphQL into the data.

new columns:

I also moved creation of a couple derivative columns to the end of graphql from generate_activity_md, since that's where most similar code already is, and they were useful earlier in the code than they had been created.

Draft, because there are some open design questions, and I haven't touched any tests:

sample output to compare with jupyterhub 2.1.0.

closes #62 closes #67

choldgraf commented 1 year ago

I just want to quickly note that I think this would be a pretty cool and useful functionality to have :-) (see #67)

minrk commented 1 year ago

I know it's been forever, but I've been using this to make the last several JupyterHub release notes, and I like it. I've updated the PR so it passes tests, at least.

I do think it warrants some options to expose to users to make different choices, and I don't know how folks would like to do that.

choldgraf commented 1 year ago

@minrk what do you think about just merging this in + cutting a release, and then iterating on configurability in future PRs? I feel like it is easier to add configurability rather than take it away.

minrk commented 1 year ago

@choldgraf it sounds fine to me, but of course I've entered everything I want as the unconfigurable default, so I have no need of options :)

choldgraf commented 1 year ago

Let's merge and iterate from there!