Closed minrk closed 1 year ago
I just want to quickly note that I think this would be a pretty cool and useful functionality to have :-) (see #67)
I know it's been forever, but I've been using this to make the last several JupyterHub release notes, and I like it. I've updated the PR so it passes tests, at least.
I do think it warrants some options to expose to users to make different choices, and I don't know how folks would like to do that.
@minrk what do you think about just merging this in + cutting a release, and then iterating on configurability in future PRs? I feel like it is easier to add configurability rather than take it away.
@choldgraf it sounds fine to me, but of course I've entered everything I want as the unconfigurable default, so I have no need of options :)
Let's merge and iterate from there!
The most important part of this is done: getting the reviewer list and committer list from graphQL into the data.
Instead of only listing the PR author, each merged PR lists contributors to the PR in order:
In practice, this means most PRs will have at least 2 names associated - the PR author and the merging maintainer.
new columns:
I also moved creation of a couple derivative columns to the end of graphql from generate_activity_md, since that's where most similar code already is, and they were useful earlier in the code than they had been created.
Draft, because there are some open design questions, and I haven't touched any tests:
sample output to compare with jupyterhub 2.1.0.
closes #62 closes #67