search

executablebooks / github-activity

Simple markdown changelogs for GitHub repositories
https://github-activity.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
49 stars 11 forks source link

NEW: add prefix CLI #75

Open agoose77 opened 2 years ago

agoose77 commented 2 years ago

This PR adds support for specifying the PR tag prefixes by the CLI. For example, I tend to use https://www.conventionalcommits.org/en/v1.0.0/ for my commit / PR titles.

I've tried to make minimal changes, so it might not be as clean as if we were writing this from scratch. Still, I think it's good enough.

Other changes:

agoose77 commented 2 years ago

@choldgraf can we delete tags.yml? It seems it was never used in the commit that introduced it: fa670a27aa5435418ced24748d74c59a59b1177c

choldgraf commented 2 years ago

This makes sense to me - though I wonder if it would be a better UX if we supported a GitHub activity yaml file where people could specify the prefixes, labels, etc they wanted to use 🤔

Either way that could probably be a follow up issue, but asking in case you think it'd significantly better and with doing here

agoose77 commented 2 years ago

@choldgraf I thought about that too. I think the answer is yes, although I initially worried about the programmatic UX for this. In fact, it's probably fine. (todo)

choldgraf commented 2 years ago

Just to clarify here - do you mean you'd like to do that in a different PR?

choldgraf commented 2 years ago

btw @agoose77 any interest in having maintainer status on this repository so that you can trigger builds, help review/merge other work, etc?

agoose77 commented 2 years ago

@choldgraf I would like to say yes, but I think just right now I might struggle to be of too much use. If it's only a small amount of work here and there I'd be happy to help!

choldgraf commented 2 years ago

No worries @agoose77 - we don't have any "official" team for this repository and so there aren't any "obligations" per se, other than to just generally try to be helpful and try to make this tool as useful as possible. I've added you to maintainer status:

https://github.com/executablebooks/github-activity/invitations