search

executablebooks / jupyter-book

Create beautiful, publication-quality books and documents from computational content.
http://jupyterbook.org
BSD 3-Clause "New" or "Revised" License
3.76k stars 652 forks source link

top left hamburger button not working #2160

Open parmentelat opened 3 weeks ago

parmentelat commented 3 weeks ago

Describe the bug

context I have noticed that my recent builds with jb1 have their "toggle primary sidebar" button no longer working; clicking the button just does almost nothing

expectation clicking the button used to collapse the left hand side toc pane, leaving more space for the main content

image

instead I am getting this

image

problem This is a problem for teachers who use the left hand side area to move from one section to the other, but who all the rest of the time need the extra space

Reproduce the bug

I am not sure exactly when this started to happen I just build my pages the same way as usual, and apparently all my books now exhibit the same behaviour this being said they all share the same settings and theme, so this is not conclusive otoh I have at least reproduced the issue after I removed all my styling, so I believe the problem is upstream

I'll keep on investigating though, in order to rule out any misconfiguration on my end any feedback from others, whether they experience the same or not with a recently created virtualenv with all the latest versions, would be helpful to me in this respect

List your environment

jupyter-book --version

Jupyter Book      : 1.0.0
External ToC      : 1.0.1
MyST-Parser       : 2.0.0
MyST-NB           : 1.1.0
Sphinx Book Theme : 1.1.2
Jupyter-Cache     : 1.0.0
NbClient          : 0.10.0
sbwiecko commented 3 weeks ago

Following recent changes to my build environment (which included updates to several Python packages), I've encountered a browser console error:

Incorrect use of

that points to <label class=sidebar-toggle... for="__secondary"...></label>

parmentelat commented 3 weeks ago

thanks @sbwiecko, this is helpful; can you confirm if you're experiencing this problem too ?

sbwiecko commented 3 weeks ago

I confirm, the toogle button doesn't work since my last build, although it worked perfectly well 2 weeks ago. image jupyter-book --version lists the exact same versions as you.

rowanc1 commented 3 weeks ago

I believe it is related to this: https://github.com/executablebooks/sphinx-book-theme/issues/836

sbwiecko commented 3 weeks ago

I believe it is related to this: executablebooks/sphinx-book-theme#836

Thank you @rowanc1 pip install pydata-sphinx-theme<0.15.3 is indeed a temporary fix.

agoose77 commented 3 weeks ago

This has now been fixed upstream, and will eventually be included in a new Jupyter Book release. I'm going to try and do that today, but it's a fiddly task! :)