search

executablebooks / jupyter-cache

A defined interface for working with a cache of executed jupyter notebooks
https://jupyter-cache.readthedocs.io
MIT License
49 stars 14 forks source link

Any reason why sqlalchemy pinned to old version (v1.3.12)? #65

Closed psychemedia closed 3 years ago

psychemedia commented 3 years ago

Is there any reason why sqlachemy is pinned to an old version (1.3.12)?

welcome[bot] commented 3 years ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

jaapz commented 3 years ago

As this package is a install requirement of myst_nb, currently I'm unable to use myst_nb in projects that also require sqlalchemy 1.4+. Pip's new dependency resolver introduced in version 20 is more strict and errors out, because 1.3.12 and 1.4 are not compatible according to pip.

Could you please either change the strictness of this version, or remove the dependency from install_requires alltogether?

psychemedia commented 3 years ago

See also a related PR in the PR queue: https://github.com/executablebooks/jupyter-cache/pull/64

choldgraf commented 3 years ago

Just FYI It looks like the tests are failing on master, so I don't think we can merge #64 until the tests are also passing (not related to #64 I know, but we can't merge a dependency change if the tests are failing). I opened up #69 to track the test failures.