search

executablebooks / markdown-it-docutils

A markdown-it plugin for implementing docutils style roles/directives.
https://executablebooks.github.io/markdown-it-docutils/
MIT License
12 stars 8 forks source link

📚 DOCS: Improve demo with autorefresh & textarea autoresize #19

Closed mgielda closed 2 years ago

mgielda commented 2 years ago

This should make the demo a bit more compelling, as having to click away scroll in the text area is not ideal.

Feel free to discard my commit messages when squash-merging this.

welcome[bot] commented 2 years ago

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:

mgielda commented 2 years ago

Thanks, welcomebot! Nice to meet you. Hope the PR is to your liking and will help convince your robotic overlords not to eradicate humanity one day.

chrisjsewell commented 2 years ago

Hmm don't know, I'll have to see what the bots say 😉

chrisjsewell commented 2 years ago

Asked and that's great cheers! I'll take your word that it works and check it out when it's built on GH pages (would be great if there was a way to preview this documentation in the PR, like I do with https://docs.readthedocs.io/en/stable/pull-requests.html)

Should also upstream this to https://github.com/executablebooks/markdown-it-plugin-template

welcome[bot] commented 2 years ago

Congrats on your first merged pull request in this project! :tada: congrats
Thank you for contributing, we are very proud of you! :heart:

mgielda commented 2 years ago

Hooray! Seems to work on gh-pages. Also the welcomebot is pleased. We are saved. Thanks @chrisjsewell for your super-snappy response and great work :)

chrisjsewell commented 2 years ago

Yeh works great cheers! (noticed it still says in the initial text you need to click away for the rendering)