👌 IMPROVE: HTML default tags - Githubissues

executablebooks / markdown-it-dollarmath

A markdown-it plugin for $-delimited math

https://executablebooks.github.io/markdown-it-dollarmath/

MIT License

4 stars 5 forks source link

👌 IMPROVE: HTML default tags #2

Closed rowanc1 closed 3 years ago

rowanc1 commented 3 years ago

Features:

Wrapped all content in a div/span, if this is not desired by the user we can encourage people to overwrite the rules completely
Removed pass-through options, see https://github.com/executablebooks/markdown-it-amsmath/issues/5
- This is backward compatible in most cases that use katex
Added an ID to the element when it it labelled
Added a labelRenderer to IOptions which allows you to override the HTML of the label.

Development:

Added json parser to rollup, couldn't get it to build without this
Added prettier ignore file to ensure md fixture are never corrected
Simplified the logic around the renderer using a factory

See also: https://github.com/executablebooks/markdown-it-amsmath/issues/1 https://github.com/executablebooks/markdown-it-amsmath/issues/5

chrisjsewell commented 3 years ago

Heya @rowanc1,quick one to start:

Added json parser to rollup, couldn't get it to build without this

Could you explain what the difficulties you had with the build without it (what errors were thrown, what issue does it solve?)

rowanc1 commented 3 years ago

Errors here:

Seems like it should be fine to add this. I can't get anything to build without it.

Fixed up the types, should be good to go.

welcome[bot] commented 3 years ago

Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart:

rowanc1 commented 3 years ago

🎉 Thanks @chrisjsewell!