Closed llimllib closed 1 year ago
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.
Welcome to the EBP community! :tada:
Heya, thanks, but I think perhaps the better way to signal public imports is with __all__
, e.g.
from .index import plugin
__all__ = ("plugin",)
Sure, I've got no preference. I'll change them to that
Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart:
According to this: https://github.com/microsoft/pyright/issues/2277, pyright expects that imports are private unless they are aliased, and they will give an error if you import them.
This PR gives all imports an alias to mark them as exported.
This comes from my project where I import some plugins as:
and get errors like this:
I also removed (what seem like) unnecesssary lint comments since flake8 isn't used any longer and ruff is not flagging those imports as unused