Closed KyleKing closed 10 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
3829c84
) 91.25% compared to head (0673224
) 92.68%.
Files | Patch % | Lines |
---|---|---|
mdit_py_plugins/admon/index.py | 95.45% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Looks good to me. :+1:
@chrisjsewell, this is a backward compatible change to resolve #93 that is ready for review when you have a chance
Just bumping this PR! It is still ready for review/merge if there are no concerns
A friendly bump! This PR is ready for review and merge.
@chrisjsewell, I would like to merge this PR when possible because I am working on adding support for a new subvariant of admonitions that would follow these changes (See https://github.com/KyleKing/mdformat-admon/issues/14 and https://github.com/KyleKing/mdformat-admon/issues/17 for Content Tabs)
Edit: the changes to support content tabs does not require changes to mdit-py-plugins
🥳. Content tabs are now supported in mdformat-admon>=1.1.0
This PR should still be merged because it makes a minor fix to the behavior of the admonitions plugin
Fixes #93
Added missing HTML roles as identified by #93(removed after clarification in a comment below)