executablebooks / mdit-py-plugins

Collection of core plugins for markdown-it-py
https://mdit-py-plugins.readthedocs.io
MIT License
30 stars 32 forks source link

👌 Expand support for Python-Markdown in the admon plugin #94

Closed KyleKing closed 10 months ago

KyleKing commented 1 year ago

Fixes #93

codecov[bot] commented 1 year ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3829c84) 91.25% compared to head (0673224) 92.68%.

Files Patch % Lines
mdit_py_plugins/admon/index.py 95.45% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #94 +/- ## ========================================== + Coverage 91.25% 92.68% +1.42% ========================================== Files 31 31 Lines 1841 1817 -24 ========================================== + Hits 1680 1684 +4 + Misses 161 133 -28 ``` | [Flag](https://app.codecov.io/gh/executablebooks/mdit-py-plugins/pull/94/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | Coverage Δ | | |---|---|---| | [pytests](https://app.codecov.io/gh/executablebooks/mdit-py-plugins/pull/94/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | `92.68% <95.45%> (+1.42%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

randomstuff commented 1 year ago

Looks good to me. :+1:

KyleKing commented 1 year ago

@chrisjsewell, this is a backward compatible change to resolve #93 that is ready for review when you have a chance

KyleKing commented 11 months ago

Just bumping this PR! It is still ready for review/merge if there are no concerns

KyleKing commented 10 months ago

A friendly bump! This PR is ready for review and merge.

@chrisjsewell, I would like to merge this PR when possible because I am working on adding support for a new subvariant of admonitions that would follow these changes (See https://github.com/KyleKing/mdformat-admon/issues/14 and https://github.com/KyleKing/mdformat-admon/issues/17 for Content Tabs)


Edit: the changes to support content tabs does not require changes to mdit-py-plugins 🥳. Content tabs are now supported in mdformat-admon>=1.1.0

This PR should still be merged because it makes a minor fix to the behavior of the admonitions plugin