executablebooks / myst-vs-code

A syntax highlighter for the MyST Markdown format
https://marketplace.visualstudio.com/items?itemName=ExecutableBookProject.myst-highlight
MIT License
35 stars 15 forks source link

🔧 Move highlighting to dependency #54

Closed chrisjsewell closed 1 year ago

rowanc1 commented 1 year ago

Hi @chrisjsewell can you add a bit more of a description to this PR that you just merged so that we can talk about these changes?

It is strange to see code being removed from this repository and moved to a non-EBP project especially for core functionality that the extension provides (syntax highlighting).

chrisjsewell commented 1 year ago

can you add a bit more of a description

As can be seen from the commit history, this repo is something essentially I created in my spare time between Mar 18-21, 2020. Since then, for nearly two years, this repo has essentially been unmaintained. Splitting off this separate concern, static syntax highlighting, something that I personally use quite frequently and have a strong interest in maintaining, makes that aspect more maintained, and by extension this whole repo more maintained (plus the new implementation improves some things)

My question to you would be, are you asking this because you/curvenote are interested in maintaining your own VS Code extension? because I'm certainly happy to collaborate