executablebooks / rst-to-myst

Convert ReStructuredText to MyST Markdown
https://rst-to-myst.readthedocs.io
MIT License
64 stars 11 forks source link

wrong directive eval_rst in table conversions #27

Closed bertabus closed 3 years ago

bertabus commented 3 years ago

Describe the problem

Table conversions that rely on eval-rst are using wrong directive "eval_rst" which doesn't actually appear to do anything in sphinx. Notice the difference in the dash and underscore.

Link to your repository or website

No response

Steps to reproduce

generate document with a table in rst that is not convertible to markdown, table with column span for example.

Simple table:

=====  =====  ======
   Inputs     Output
------------  ------
  A      B    A or B
=====  =====  ======
False  False  False
True   False  True
False  True   True
True   True   True
=====  =====  ======

the converted output will have incorrect directive (notice the underscore)

```{eval_rst}
Simple table:

=====  =====  ======
   Inputs     Output
------------  ------
  A      B    A or B
=====  =====  ======
False  False  False
True   False  True
False  True   True
True   True   True
=====  =====  ======


hand editing the underscore to be a dash allows sphinx to correctly build the converted markdown. 

### The version of Python you're using

_No response_

### Your operating system

_No response_

### Versions of your packages

_No response_

### Additional context

_No response_
welcome[bot] commented 3 years ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada: