Closed zsol closed 1 year ago
Base: 84.27% // Head: 84.40% // Increases project coverage by +0.12%
:tada:
Coverage data is based on head (
1c94475
) compared to base (13c6fb1
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Thanks, do you want to look into adding a test?
My only thought though, is that perhaps there should be a warning and/or some hint in the output, that this conversion (and this loss of information) occurred
Oh! Hi! :) Yeah, of course. I can add a warning as well as a test case.
Done!
Hey @zsol, from the lack of test coverage, I realised your test example wasn't actually a doctest block 😅
So I fixed it, and also added the pycon
pygment lexer to the output block.
Have a look, and let me know if that looks ok
Oh 😆 thanks for fixing :) lgtm
Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart:
Currently these are treated like a paragraph. Treating them like a
literal_block
is better.