executablebooks / rst-to-myst

Convert ReStructuredText to MyST Markdown
https://rst-to-myst.readthedocs.io
MIT License
59 stars 10 forks source link

πŸ› FIX: CLI option callbacks with --config #60

Closed chrisjsewell closed 1 year ago

chrisjsewell commented 1 year ago

These option value should be unprocessed. This also fixes a bug with the directive data caching.

chrisjsewell commented 1 year ago

@goxberry I believe this is a better alternative to #52 πŸ˜… ?

codecov[bot] commented 1 year ago

Codecov Report

Base: 84.48% // Head: 85.76% // Increases project coverage by +1.28% :tada:

Coverage data is based on head (15786d6) compared to base (c660937). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #60 +/- ## ========================================== + Coverage 84.48% 85.76% +1.28% ========================================== Files 10 10 Lines 1637 1637 ========================================== + Hits 1383 1404 +21 + Misses 254 233 -21 ``` | Flag | Coverage Ξ” | | |---|---|---| | pytests | `85.76% <100.00%> (+1.28%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/executablebooks/rst-to-myst/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks) | Coverage Ξ” | | |---|---|---| | [rst\_to\_myst/cli.py](https://codecov.io/gh/executablebooks/rst-to-myst/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#diff-cnN0X3RvX215c3QvY2xpLnB5) | `86.45% <ΓΈ> (+2.60%)` | :arrow_up: | | [rst\_to\_myst/parser.py](https://codecov.io/gh/executablebooks/rst-to-myst/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#diff-cnN0X3RvX215c3QvcGFyc2VyLnB5) | `95.74% <100.00%> (+1.06%)` | :arrow_up: | | [rst\_to\_myst/markdownit.py](https://codecov.io/gh/executablebooks/rst-to-myst/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#diff-cnN0X3RvX215c3QvbWFya2Rvd25pdC5weQ==) | `92.28% <0.00%> (+0.24%)` | :arrow_up: | | [rst\_to\_myst/inliner.py](https://codecov.io/gh/executablebooks/rst-to-myst/pull/60?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks#diff-cnN0X3RvX215c3QvaW5saW5lci5weQ==) | `73.28% <0.00%> (+3.43%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=executablebooks)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

goxberry commented 1 year ago

@chrisjsewell Agreed.