executablebooks / sphinx-book-theme

A clean book theme for scientific explanations and documentation with Sphinx
https://sphinx-book-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
438 stars 201 forks source link

Replace libsass with pure python implementation #195

Closed hason closed 4 years ago

hason commented 4 years ago

I want to create a docker image based on alpine linux for sphinx and this awesome theme. Libsass package is too complicated, it must be compiled and it is too heavy (~60MB) also. Would it be possible to replace it with another written in pure python? For example https://github.com/Kronuz/pyScss?

welcome[bot] commented 4 years ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

chrisjsewell commented 4 years ago

Thanks @hason, well @pradyunsg this is the pro for trying to make our previous setup work; whereby the SCSS is pre-compiled in the released package (and checked to be up-to-date with pre-commit)

pradyunsg commented 4 years ago

Any compliant SCSS compiler works TBH.

I don't remember if we compile the SCSS prior to release, but if we do, we could theoretically make the runtime SCSS compilation an optional feature?

chrisjsewell commented 4 years ago

I don't remember if we compile the SCSS prior to release

You removed it in fbb8b18d03c95966639e3d3482c5a30d03684bd5 😉

chrisjsewell commented 4 years ago

Or yeh just change the package, I don't see an issue with that