executablebooks / sphinx-book-theme

A clean book theme for scientific explanations and documentation with Sphinx
https://sphinx-book-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
431 stars 197 forks source link

UPGRADE/BREAKING: PyData v0.13 and HTML refactoring #677

Closed choldgraf closed 1 year ago

choldgraf commented 1 year ago

This brings in several more updates for the PyData theme 0.13. It also adds support for several features that folks have requested.

That's pretty much it so far! @mmcky or @AakashGfude can you find anything else we need to change?

To do

choldgraf commented 1 year ago

Alright I've pinned us to the next pydata pre-release, so this should let us pull from PyPI. I've also made several updates to the theme based on the latest changes in PyData, and re-worked the documentation a bit to be easier to parse.

I think that this PR is too gigantic to be reviewed piece by piece, so I suggest that we merge it and focus on making iterative improvements moving forward.

Let's see how the tests go, and if they pass I intend to merge this and then cut a pre-release once @AakashGfude fixes up #584 . Then we can have another testing phase for people to provide feedback before a full release (and in the meantime, I think pydata will make a new version release too).

@AakashGfude this will also un-break the tests so that you can test out the PyPI fix without having the extra broken tests noise.

choldgraf commented 1 year ago

OK tests are happy, so I'll merge this one and update your branch @AakashGfude

consideRatio commented 1 year ago

Wieeeeeee!!! Amazing work! Super excited to see soo many issues resolve :)

I thought all these notifications of closed issues maybe was a mistake as they closed the very same minute, but wow - its because of this PR! I've never seen a PR resolve soo many issues in one go!! @choldgraf you hold the record now :D

:1st_place_medal: :tada: :sunflower: :heart:

choldgraf commented 1 year ago

Haha to be fair many of these were inherited from the pydata theme, which has had a lot of work from many people over the months

James11222 commented 1 year ago

Sorry I'm a little bit of a Github novice and don't really know how all of this works. So does this mean I can now toggle dark mode in Jupyter books? Or is there still a little bit of time we have to wait for a new version on the website or something?

choldgraf commented 1 year ago

It will be possible soon! We must first "make a release of this theme", and then in Jupyter book we must update the version and then make a release there too. Then it'll be available for jupyter book users 👍