executablebooks / sphinx-book-theme

A clean book theme for scientific explanations and documentation with Sphinx
https://sphinx-book-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
431 stars 197 forks source link

sphinx-book-theme causes sphinx-build to crash #685

Closed bradbell closed 1 year ago

bradbell commented 1 year ago

Describe the bug

sphinx-build -b html build/rst build/html Running Sphinx v5.0.2 loading pickled environment... done building [mo]: targets for 0 po files that are out of date building [html]: targets for 2 source files that are out of date updating environment: 0 added, 2 changed, 0 removed reading sources... [100%] index
looking for now-outdated files... none found pickling environment... done checking consistency... done preparing documents... done /home/bradbell/.local/lib/python3.11/site-packages/pydata_sphinx_theme/bootstrap_html_translator.py:27: RemovedInSphinx60Warning: generate_targets_for_table() is deprecated
self.generate_targets_for_table(node)

Exception occurred: File "/home/bradbell/.local/lib/python3.11/site-packages/pydata_sphinx_theme/bootstrap_html_translator.py", line 29, in visit_table self._table_row_index = 0 ^^^^^^^^^^^^^^^^^^^^^ AttributeError: property '_table_row_index' of 'BootstrapHTML5Translator' object has no setter The full traceback has been saved in /tmp/sphinx-err-tiy3mvim.log, if you want to report the issue to the developers. Please also report this if it was a user error, so that a better error message can be provided next time. A bug report can be filed in the tracker at https://github.com/sphinx-doc/sphinx/issues. Thanks!

Reproduce the bug

Execute the following bash script (note that if you change sphinx_book_theme to sphinx_rtd_theme, the build works without error.

#! /usr/bin/env bash
set -e
dir='build/rst'
#
if [ -e $dir ]
then
   rm -r $dir
fi
mkdir -p $dir

#
# conf.py
cat << EOF > $dir/conf.py
html_theme = "sphinx_book_theme"
EOF
#
# example.rst
cat << EOF > $dir/example.rst
Examples
########

.. csv-table::
   :header:  "Name", "Title"
   :widths: auto

   name,title
EOF
#
# index.rst
cat << EOF > $dir/index.rst
xrst
####

.. toctree::

   example
EOF
#
echo "sphinx-build -b html $dir build/html"
sphinx-build -b html $dir build/html

List your environment

cppad.git>uname -a
Linux fedora 6.1.8-200.fc37.x86_64 #1 SMP PREEMPT_DYNAMIC Tue Jan 24 20:32:16 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
dnf info python3-sphinx
Last metadata expiration check: 4:30:00 ago on Sun 19 Feb 2023 01:26:09 AM MST.
Installed Packages
Name         : python3-sphinx
Epoch        : 1
Version      : 5.0.2
Release      : 2.fc37
Architecture : noarch
Size         : 11 M
Source       : python-sphinx-5.0.2-2.fc37.src.rpm
pip show sphinx-book-theme
Name: sphinx-book-theme
Version: 0.0.39
Summary: Jupyter Book: Create an online book with Jupyter Notebooks
Home-page: https://jupyterbook.org/
Author: Project Jupyter Contributors
Author-email: jupyter@googlegroups.com
License: BSD
Location: /home/bradbell/.local/lib/python3.11/site-packages
Requires: beautifulsoup4, click, docutils, pydata-sphinx-theme, pyyaml, sphinx
Required-by: xrst
welcome[bot] commented 1 year ago

Thanks for opening your first issue here! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out EBP's Code of Conduct. Also, please try to follow the issue template as it helps other community members to contribute more effectively.
If your issue is a feature request, others may react to it, to raise its prominence (see Feature Voting).
Welcome to the EBP community! :tada:

choldgraf commented 1 year ago

This should be fixed in the latest pre-release, give it a shot here:

I'll close but please re-post if it's still broken w/ the latest versoin

bradbell commented 1 year ago

Works for me.