Better early return for add_launch_buttons if no launch buttons

executablebooks / sphinx-book-theme

A clean book theme for scientific explanations and documentation with Sphinx

https://sphinx-book-theme.readthedocs.io

BSD 3-Clause "New" or "Revised" License

431 stars 197 forks source link

Better early return for add_launch_buttons if no launch buttons #693

Closed paugier closed 1 year ago

paugier commented 1 year ago

Fixes https://github.com/executablebooks/jupyter-book/issues/1463

See https://github.com/executablebooks/jupyter-book/issues/1463#issuecomment-1445131176

Is it enough?

choldgraf commented 1 year ago

Nice - this looks correct to me. Could you just add a test to make sure that if none if them are there, then there is no launch buttons dropdo container on the page?

welcome[bot] commented 1 year ago

Congrats on your first merged pull request in this project! :tada:
Thank you for contributing, we are very proud of you! :heart:

choldgraf commented 1 year ago

actually, no worries I will add a test in #691 - many thanks for this improvement :-)