search

executablebooks / sphinx-book-theme

A clean book theme for scientific explanations and documentation with Sphinx
https://sphinx-book-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
429 stars 198 forks source link

RLS 1.0.0: (repeat) Fix a link and improve test reliability #701

Closed choldgraf closed 1 year ago

choldgraf commented 1 year ago

We got bitten by a codecov rate limit bug (cc @AakashGfude you mentioned this in slack too) and then got bitten by a linkcheck that broke only after the release had been made. I don't think we want to block release actions on broken links, so this just runs the codecov + the linkcheck jobs on the pull_request event, which means it won't trigger on the release event.

choldgraf commented 1 year ago

I'll wait for the linkcheck to complete on this PR, and also to confirm that codecov also runs, and will merge if so. Then we can double check that the jobs don't run on main. If so I'll cut a new release