search

executablebooks / sphinx-book-theme

A clean book theme for scientific explanations and documentation with Sphinx
https://sphinx-book-theme.readthedocs.io
BSD 3-Clause "New" or "Revised" License
429 stars 198 forks source link

Fullscreen behaviour is not consistent when changing pages #702

Open mathbunnyru opened 1 year ago

mathbunnyru commented 1 year ago

Describe the bug

When I open a page in fullscreen and then go to another page, it does different things in different browsers. I'm using the macOS operating system.

  1. Vivaldi (Chromium based) exits the fullscreen mode (not expected).
  2. Safari changes the page correctly, but pressing the "fullscreen" button again doesn't exit the fullscreen.

Reproduce the bug

  1. Open https://jupyter-docker-stacks.readthedocs.io/en/latest/index.html
  2. Press the "Fullscreen mode" button
  3. On the left side, press any section

List your environment

I'm using freshly released sphinx-book-theme 1.0.0 and sphinx 6.1.3

choldgraf commented 1 year ago

Did this used to work on and old version and now has changed the behavior? I wonder if this is just browser-dependent since we are just using the browsers Fullscreen function.

mathbunnyru commented 1 year ago

The behaviour is the same with sphinx-book-theme==0.3.3.